Promote SWE-Agent V2 example#1741
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request promotes the swe-agent-v2 example from the experimental directory to the main examples directory, updating all documentation and relative paths. Additionally, it refactors the launcher script run.py to introduce configurable parameters for rollout limits, save intervals, and trace directories, while updating default settings such as increasing max_seq_len to 65536. Feedback is provided regarding the removal of the --use-miles-router flag in run.py, which could unintentionally bypass the Miles Router and disrupt Token-In-Token-Out (TITO) multi-turn agentic rollouts.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "--sglang-mem-fraction-static 0.7 " | ||
| "--sglang-tool-call-parser glm47 " | ||
| "--sglang-reasoning-parser glm45 " | ||
| "--use-miles-router " | ||
| "--sglang-router-port 31000 " |
There was a problem hiding this comment.
The --use-miles-router flag was removed from sglang_args. Since this launcher is intended to use the Miles session server and router for TITO (Token-In-Token-Out) multi-turn agentic rollout (as documented in the README and agentic-chat-template.md), omitting this flag might cause SGLang to bypass the Miles Router, potentially breaking TITO or session tracing.
Please verify if this removal was intentional. If not, it should be restored to ensure proper routing through the Miles session server.
| "--sglang-mem-fraction-static 0.7 " | |
| "--sglang-tool-call-parser glm47 " | |
| "--sglang-reasoning-parser glm45 " | |
| "--use-miles-router " | |
| "--sglang-router-port 31000 " | |
| "--sglang-mem-fraction-static 0.7 " | |
| "--sglang-tool-call-parser glm47 " | |
| "--sglang-reasoning-parser glm45 " | |
| "--use-miles-router " | |
| "--sglang-router-port 31000 " |
1 participant
Promotes the validated SWE-Agent V2 example from examples/experimental to examples/swe-agent-v2.\n\nUpdates the recipe to use the public harbor-framework/harbor branch harbor-miles-v0.13.1 and removes the stale harbor-private launcher. The unrelated GLM-4.7 GSM8K reasoning launchers remain experimental in their own folder.\n\nValidation: one-node 8xH200 GLM-4.7-Flash synchronous smoke run on Terminal-Bench; all 8 Harbor agents completed with numbered steps and zero callback connection errors, Megatron emitted train/step 0, traces were written, and Ray exited SUCCEEDED. Python launchers also pass py_compile and git diff --check.